[sled-storage] Use test-configured mountpoint root for datasets #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discovered this while working on #6782 - after this PR, it's possible to use the "ensure dataset" calls as a part of the |
andrewjstone
approved these changes
Nov 20, 2024
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should only impact tests.
The "mountpoint" configuration, by default, uses the
ZPOOL_MOUNTPOINT_ROOTas a root path where datasetsmay be located:
omicron/sled-storage/src/config.rs
Lines 33 to 35 in 48790e5
In prod, this value is "/". Under tests, however, we may want more isolation between datasets, hence this configuration option.
This PR respects that configuration option when configuring datasets. This will be relevant for Sled Agent tests, and otherwise effectively acts as a no-op.